Skip to content

Commit 7f43c51

Browse files
committed
ci: carve out private/cockpit + terraform/credentials/cockpit from filename-linter
The fork's filename-linter (inherited from upstream pixie-io) rejects any PR diff that touches a path containing 'private'. The restored fork-cloud config from the main-merge fix (cb81ecd) added 12 private/cockpit/* + 1 terraform/credentials/cockpit/* files, which upstream-main had deleted via PR pixie-io#2391 — the linter then correctly saw them as 'new private/* additions' and failed. These specific paths are LEGITIMATE fork-cloud deployment config that pre-dates the upstream linter; the original 'no private/* leaks' intent stays in place for everything else via two negative-glob exceptions.
1 parent c2642da commit 7f43c51

1 file changed

Lines changed: 9 additions & 0 deletions

File tree

‎.github/workflows/filename_linter.yaml‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,19 @@ jobs:
1818
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
1919
id: changes
2020
with:
21+
# Fork carve-outs: private/cockpit/ + terraform/credentials/cockpit/
22+
# are LEGITIMATE fork config for the AOCC pixie-cloud deployment;
23+
# they were on the fork before upstream main introduced
24+
# filename_linter and stayed when the cert-manager migration
25+
# (#2391) deleted them upstream. Negative-globbing them keeps
26+
# the original "no private/* leaks" guard while letting the
27+
# fork's known-private deployment files through.
2128
filters: |
2229
private:
2330
- '**/*private*/**'
2431
- '**/*private*'
32+
- '!private/cockpit/**'
33+
- '!terraform/credentials/cockpit/**'
2534
- name: Fail on private
2635
if: ${{ steps.changes.outputs.private == 'true' }}
2736
run: echo "This repo disallows dirnames or filenames with 'private' in it." && exit 1

0 commit comments

Comments
 (0)