Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to disable OverlappingRanges using the config file #163

Open
TothFerenc opened this issue Nov 10, 2021 · 0 comments · May be fixed by #164
Open

Unable to disable OverlappingRanges using the config file #163

TothFerenc opened this issue Nov 10, 2021 · 0 comments · May be fixed by #164

Comments

@TothFerenc
Copy link
Contributor

OverlappingRanges feature is enabled by default, this way:
https://github.com/k8snetworkplumbingwg/whereabouts/blob/master/pkg/config/config.go#L38

Later on, the config file (flatfile) is processed and those values are merged to the actual IPAM config struct.
Once this OverlappingRanges is set to True, we cannot override it to False. I believe the problem is that a boolean variable has no "undefined" value, just True or False. In case of False, we don't know whether it is unset or intentionally set to False.

So we cannot disable the OverlappingRanges via config file, we need to disable it in every NAD, which is not a feasible option.

@TothFerenc TothFerenc linked a pull request Nov 10, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant