Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use per node device plugin config hash #619

Open
adrianchiris opened this issue Feb 6, 2024 · 2 comments
Open

Use per node device plugin config hash #619

adrianchiris opened this issue Feb 6, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@adrianchiris
Copy link
Collaborator

adrianchiris commented Feb 6, 2024

Today SriovNetworkNodeState.Spec.dpConfigVersion contains the (fnv)hash of device plugin config map data.
that means that each time this config us updated, this hash willl change and trigger reconcile of config daemon.

Since this config map contains per-node device plugin configurations, it only makes sense to calculate hash for the specific node data instead of the entire thing thus preventing un-needed operations by sriov config daemon.

a non-existing sriov config map and an "empty" entry in the config map for the node should yield the same hash.
since intially config map will not exist.

apiVersion: v1
data:
  worker-node-2: '{"resourceList":null}'
kind: ConfigMap
metadata:
  creationTimestamp: "2024-02-06T11:59:28Z"
  name: device-plugin-config
  namespace: sriov-network-operator
  resourceVersion: "9112888"
  uid: 59155454-a365-4c95-b2d5-bace3e06d01f
@adrianchiris adrianchiris added the enhancement New feature or request label Feb 6, 2024
@SchSeba
Copy link
Collaborator

SchSeba commented Feb 12, 2024

question here I never understand why we really need the dpConfigVersion can we drop that ?

@SchSeba
Copy link
Collaborator

SchSeba commented Apr 4, 2024

This PR #669 should remove it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants