Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makefile GODOC variable is not used #154

Open
mrymsza opened this issue Nov 25, 2020 · 0 comments
Open

makefile GODOC variable is not used #154

mrymsza opened this issue Nov 25, 2020 · 0 comments

Comments

@mrymsza
Copy link
Contributor

mrymsza commented Nov 25, 2020 •
edited
Loading

What issue would you like to bring attention to?

Makefile contains some unused and unnecessary variables and comments. The layout of the file is also inconsistent (some sections are named others aren't).

What is the impact of this issue?

Makefile is no longer clear and easy to read.

Do you have a proposed response or remediation for the issue?

All of the variables should be kept at the top of the file, the comments should be either removed or placed before every section.
@mrymsza mrymsza changed the title Makefile: cleanup variables and comments. makefile GODOC variable is not used Nov 25, 2020
@mrymsza mrymsza mentioned this issue Nov 26, 2020
Closed
@adrianchiris adrianchiris mentioned this issue May 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean up Makefile variables and comments
1 participant
@mrymsza