Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[k3s-upgrade] MODIFIED_VERSION is undefined #10750

Open
janpieper opened this issue Aug 23, 2024 · 2 comments
Open

[k3s-upgrade] MODIFIED_VERSION is undefined #10750

janpieper opened this issue Aug 23, 2024 · 2 comments
Assignees

Comments

@janpieper
Copy link

I cannot create an issue in https://github.com/k3s-io/k3s-upgrade, so I try it here 😉


The commit k3s-io/k3s-upgrade@243b18c (~4 years old) has introduced a variable called MODIFIED_VERSION which is undefined, so the script only outputs

[INFO] Waiting for all master nodes to be upgraded to version

instead of e.g.

[INFO] Waiting for all master nodes to be upgraded to version v1.29.8+k3s1

This variable is still used in the latest version: scripts/upgrade.sh @ k3s-upgrade, but it is still undefined 😉

@brandond
Copy link
Contributor

Yeah, that var was mostly nixed in code review on that PR, but it appears that one use of it was left in.

@brandond
Copy link
Contributor

thanks for the report! Should be fixed for next month's releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To Test
Development

No branches or pull requests

3 participants