[Release-1.28] - k3s etcd-snapshot commands run against server specified in config file, instead of local server

[brandond]

Backport fix for k3s etcd-snapshot commands run against server specified in config file, instead of local server

• k3s etcd-snapshot commands run against server specified in config file, instead of local server #10513

[fmoral2]

Validated on Version:

-$k3s version v1.28.11+k3s-edc7ea53 (edc7ea53)

Environment Details

Infrastructure
Cloud EC2 instance

Node(s) CPU architecture, OS, and Version:
ubuntu
AMD

Cluster Configuration:
-3 node server
-1 node agents

Steps to validate the fix

1. Install k3s etcd embedded
2. Take etcd snapshot on the second server
3. Validate its taken on the correct place ( second server )

Reproduction Issue:

 
k3s version v1.30.2+k3s-58ab2592 (58ab2592)

Server 1 - ip 172-test1
Server 2 - ip 172-test2
Server 3 - ip 172-test3


on Server 2 
k3s etcd-snapshot save
INFO[0000] Snapshot on-demand-ip-172-test1.us-east-2.compute.internal-1721316392 saved. 

- Saved on first Server



k3s etcd-snapshot list
Name                                                             Location                                                                                                         Size    Created
on-demand-ip-172-test1.us-east-2.compute.internal-1721316392 file://{redacted}ip-172-test1.us-east-2.compute.internal-    2024-07-18T15:26:32Z

- List shows the snapshot is saved on the first server

Validation Results:

 
 k3s version v1.30.2+k3s-37830fe1 (37830fe1)

 Server 1 - ip 172-test1
Server 2 - ip 172-test2
Server 3 - ip 172-test3


- on Server 2 
$ sudo k3s etcd-snapshot save 

INFO[0001] Snapshot on-demand-ip-172-test2.us-east-2.compute.internal-1721321853 saved. 

k3s etcd-snapshot list

Name                                                             Location                                                                                                         Size    Created
on-demand-ip-172-test2.us-east-2.compute.internal-1721321853 file://{redacted}ip-172-test2.us-east-2.compute.internal-    2024-07-18T15:26:32Z


$ sudo k3s etcd-snapshot save --etcd-server https://localhost:6443
INFO[0000] Snapshot on-demand-ip-172-test2.us-east-2.compute.internal-1721322104 saved. 


Snapshot pointing to first server also works
~$ sudo k3s etcd-snapshot save --etcd-server https://172-test1:6443
INFO[0000] Snapshot on-demand-ip-172-test1.us-east-2.compute.internal-1721322170 saved. 




- on server 1
$ sudo k3s etcd-snapshot save 
INFO[0003] Snapshot on-demand-ip-172-test1.us-east-2.compute.internal-1721321767 saved. 


k3s etcd-snapshot list

Name                                                             Location                                                                                                         Size    Created
on-demand-ip-172-test1.us-east-2.compute.internal-1721321853 file://{redacted}ip-172-test2.us-east-2.compute.internal-    2024-07-18T15:26:32Z