Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to pkg/agent/loadbalancer #10505

Open
brandond opened this issue Jul 12, 2024 · 0 comments
Open

Add tests to pkg/agent/loadbalancer #10505

brandond opened this issue Jul 12, 2024 · 0 comments
Assignees

Comments

@brandond
Copy link
Member

The loadbalancer package is somewhat complicated, and is critical to inter-node communication. It maintains a fair bit of state and has many code paths that hold locks.

We need to add tests to this package to ensure that the loadbalancer behaves as intended at all times, and that changes do not trigger hard to diagnose failures, lock-related or otherwise. In particular, we should test concurrent failover, health checking, and server addition/removal, as these are paths that will hold interleaving read and write locks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Next Up
Development

No branches or pull requests

1 participant