i cannot figure out "nodefilter" - its not documented

[bukowa]

Can someone explain it to me? I can make a pull request with that information.

[bukowa]

Nodefilter starts with one of the existing roles (group).

https://github.com/rancher/k3d/blob/601bef45d7c9ed70be4afb534aa780ac6ecef7fd/pkg/types/types.go#L79-L85

Or all:
https://github.com/rancher/k3d/blob/092f26a4e27eaf9d3a5bc32b249f897f448bc1ce/pkg/util/filter.go#L76-L77

Regex used to match:
https://github.com/rancher/k3d/blob/092f26a4e27eaf9d3a5bc32b249f897f448bc1ce/pkg/util/filter.go#L35

And then you can define a subset in brackets []:

server[0,1,2]
https://github.com/rancher/k3d/blob/092f26a4e27eaf9d3a5bc32b249f897f448bc1ce/pkg/util/filter.go#L98-L99
agent[0:3]
https://github.com/rancher/k3d/blob/092f26a4e27eaf9d3a5bc32b249f897f448bc1ce/pkg/util/filter.go#L116-L117
all[*]
https://github.com/rancher/k3d/blob/092f26a4e27eaf9d3a5bc32b249f897f448bc1ce/pkg/util/filter.go#L161-L162

But using list as: server[0,1,2] is not working:

←[31mFATA←[0m[0000] Failed to parse node filters: invalid format or empty subset in 'server[0'

Why?

[iwilltry42]

Hey @bukowa , you did good investigation there!
The issue you see is (most probably, as I didn't check in depth) caused by the incompatibility of Cobra's StringArray flag type with the newly used Viper config library.
Due to this incompatibility, we had to switch to StringSlice type flags, which unfortunately split on , in flag values.
We hope this can be resolved rather soon once it got fixed upstream.

[bukowa]

Thanks for input. I think you might also want to check #519 - it may be related somehow.

[iwilltry42]

Leaving this here as well to mark this thread as the answer: https://k3d.io/v5.4.1/design/concepts/#nodefilters

[alexdresko]

I landed on this page while trying to understand nodefilter. I hadn't seen that used elsewhere in Docker or Kubernetes. It appears to be a k3d-specific feature.

It makes a little more sense to me, especially after looking at the links @bukowa posted.

But I do think it would be a good idea to have a doc page that explains nodefilter clearly.

[iwilltry42]

Hey there 👋
What about https://k3d.io/v5.4.1/design/concepts/#nodefilters ? 🙂