Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[help wanted] Support AMD GPU #196

Open
csukuangfj opened this issue Jul 5, 2023 · 4 comments · May be fixed by #1110
Open

[help wanted] Support AMD GPU #196

csukuangfj opened this issue Jul 5, 2023 · 4 comments · May be fixed by #1110
Labels
help wanted Extra attention is needed

Comments

@csukuangfj
Copy link
Collaborator

#153 added support for NVIDIA GPUs.

We also need to support AMD GPUs.

We need to integrate
https://onnxruntime.ai/docs/execution-providers/MIGraphX-ExecutionProvider.html
into sherpa-onnx.

Help from the community is highly appreciated.

Please leave a comment if you would like to help. We can help you if you meet any problems during the intergration.

@csukuangfj csukuangfj added the help wanted Extra attention is needed label Jul 5, 2023
@paolo-caroni
Copy link
Contributor

I would point that an OpenCL implementation would be better, since it will be vendor independent.
But I've read that an OpenCL implemenation in ONNX is very difficult.
For AMD GPUs there is a compatibility layer called ZLUDA, but I haven't tested it.

@thewh1teagle
Copy link
Contributor

thewh1teagle commented Jul 6, 2024

We also need to support AMD GPUs.

Maybe we can inspire from pykeio/ort it uses AMD ROCm

Or from ggerganov/whisper.cpp that uses CNugteren/CLBlast

Another promising option
https://github.com/ROCm/HIP

@thewh1teagle
Copy link
Contributor

@csukuangfj
Is there a specific reason you prefer MIGraphX? Since it depends on many 3rd libs while Rocm looks simpler.
In addition it seems that it's gonna be pretty simple to add support for it similar to the PR of Cuda.
But for some reason the PR with cuda didn't prepared for any other GPU backend so need refactor there.

@csukuangfj
Copy link
Collaborator Author

Is there a specific reason you prefer MIGraphX?

No, I listed it since when I searched with Google for how to use AMD GPUs with onnxruntime, it gave me
the link https://onnxruntime.ai/docs/execution-providers/MIGraphX-ExecutionProvider.html

I don't have any preferences for which one to use, as long as we can achieve the goal: Support AMD GPU.

If you could contribute, that would be great. If you have any issues, we would like to help you at any time..

@csukuangfj csukuangfj linked a pull request Jul 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants