New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SM: Installing jxcore-addon fails on Ubuntu and RedHat #7

Open

ktrzeciaknubisa opened this issue Jul 18, 2015 · 1 comment

Member

ktrzeciaknubisa commented Jul 18, 2015

Once I type jx install (SM) in addon's directory, I get :

/home/azureuser/.node-gyp/jxb304/src/jscpucfg.h:101:3: 
error: #error "Cannot determine endianness of your platform. Please add support to jscpucfg.h."
make: *** [Release/obj.target/binding/binding.o] Error 1

Fails on Ubuntu and RedHat.
Works on OSX and Suse.

The text was updated successfully, but these errors were encountered:

andrew-aladev commented Sep 2, 2016 •

edited

Loading

if (variables.OS == 'mac' || variables.OS == "ios") {
  defaults.defines = defaults.defines.concat(['JS_HAVE_MACHINE_ENDIAN_H=1',
    'XP_MACOSX=1',
    'DARWIN=1']);
} else if (osInfo.isLinux || variables.OS == "android") {
  defaults.defines.push('JS_HAVE_ENDIAN_H');
}

osInfo.isLinux is false but variables.OS is linux. So we have JS_HAVE_ENDIAN_H undefined and we couldn't try endian.h.

It looks like my OSInfo returns isGentoo: true, isLinux: false. But gentoo is a linux.

We need to rewrite this jx_utils in future. For now we can use patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment