Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate spec parsing from URL parsing #186

Open
jwodder opened this issue Feb 16, 2024 · 0 comments
Open

Separate spec parsing from URL parsing #186

jwodder opened this issue Feb 16, 2024 · 0 comments
Labels
breaking change Introduction of an incompatible API change under consideration Dev has not yet decided whether or how to implement

Comments

@jwodder
Copy link
Owner

jwodder commented Feb 16, 2024

  • Make GHRepo::from_str and impl serde::Deserialize for GHRepo only accept strings of the form {owner}/{name}
  • Give GHRepo a dedicated method for parsing from a GitHub repository URL
  • Give GHRepo a dedicated method for parsing from either a URL or a repository spec
  • Add a function for use in #[serde(deserialize_with)] that deserializes GHRepo values only from GitHub repository URLs
  • Add a function for use in #[serde(deserialize_with)] that deserializes GHRepo values from either URLs or repository specs
@jwodder jwodder added breaking change Introduction of an incompatible API change under consideration Dev has not yet decided whether or how to implement labels Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change Introduction of an incompatible API change under consideration Dev has not yet decided whether or how to implement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jwodder