Add split and split-re tags (#55) #93
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
==========================================
+ Coverage 79.13% 79.57% +0.44%
==========================================
Files 4 4
Lines 369 377 +8
Branches 17 17
==========================================
+ Hits 292 300 +8
Misses 60 60
Partials 17 17
Continue to review full report at Codecov.
|
|
Any thoughts on that? Do I close it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #55
This PR adds two more reader tags:
#splitand#split-re. According to my experience, both tags are useful. Most of our projects carry code to extend built-int tags with these ones to accept comma-separated values from Env vars.Usage:
{:hosts #split "app1.host.com,app2.host.com"} {:hosts #split #env APP_HOSTS} {:hosts #split-re ["\\t" "app1.host.com\tapp2.host.com"]}