Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with planck #54

Open
cap10morgan opened this issue Sep 13, 2017 · 1 comment
Open

Doesn't work with planck #54

cap10morgan opened this issue Sep 13, 2017 · 1 comment

Comments

@cap10morgan
Copy link

I tried using this with planck after installing it to my local Maven repo and then running:

planck -D aero:1.1.2
(Planck REPL starts up)

cljs.user=> (require '[aero.core :as aero])
No such namespace: cljs.nodejs, could not locate cljs/nodejs.cljs, cljs/nodejs.cljc, or JavaScript source providing "cljs.nodejs" in file aero/core.cljc
@SevereOverfl0w
Copy link
Contributor

Aero relies on nodejs for it's filesystem integration. I think a PR to make aero work without nodejs would be useful, but it's difficult to do in a backwards compatible way at this point. You could detect whether there's a js/require available, and if so look if the string is available as a file, otherwise fall back onto a cljs.tools.reader.reader-types/IPushbackReader (which should really be all it takes)

SevereOverfl0w added a commit that referenced this issue May 20, 2019
SevereOverfl0w added a commit that referenced this issue May 20, 2019
SevereOverfl0w added a commit that referenced this issue May 20, 2019
SevereOverfl0w added a commit that referenced this issue Jun 2, 2019
SevereOverfl0w added a commit that referenced this issue Jun 2, 2019
SevereOverfl0w added a commit that referenced this issue Jun 2, 2019
SevereOverfl0w added a commit that referenced this issue Jun 2, 2019
malcolmsparks pushed a commit that referenced this issue Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants