From 2af655dec0aee1adb274bd5867784339efe1097c Mon Sep 17 00:00:00 2001 From: Jake Teton-Landis Date: Sat, 31 Aug 2024 16:34:23 -0400 Subject: [PATCH] disable asyncify-advise, its just really spammy --- packages/variant-quickjs-ng-wasmfile-debug-asyncify/Makefile | 1 - packages/variant-quickjs-ng-wasmfile-debug-asyncify/README.md | 1 - .../variant-quickjs-singlefile-browser-debug-asyncify/Makefile | 1 - .../variant-quickjs-singlefile-browser-debug-asyncify/README.md | 1 - packages/variant-quickjs-singlefile-cjs-debug-asyncify/Makefile | 1 - .../variant-quickjs-singlefile-cjs-debug-asyncify/README.md | 1 - packages/variant-quickjs-singlefile-mjs-debug-asyncify/Makefile | 1 - .../variant-quickjs-singlefile-mjs-debug-asyncify/README.md | 1 - packages/variant-quickjs-wasmfile-debug-asyncify/Makefile | 1 - packages/variant-quickjs-wasmfile-debug-asyncify/README.md | 1 - scripts/prepareVariants.ts | 2 +- 11 files changed, 1 insertion(+), 11 deletions(-) diff --git a/packages/variant-quickjs-ng-wasmfile-debug-asyncify/Makefile b/packages/variant-quickjs-ng-wasmfile-debug-asyncify/Makefile index 7ddc5392..503b6680 100644 --- a/packages/variant-quickjs-ng-wasmfile-debug-asyncify/Makefile +++ b/packages/variant-quickjs-ng-wasmfile-debug-asyncify/Makefile @@ -91,7 +91,6 @@ CFLAGS_WASM+=--pre-js $(TEMPLATES)/pre-extension.js CFLAGS_WASM+=--pre-js $(TEMPLATES)/pre-sourceMapJson.js CFLAGS_WASM+=--pre-js $(TEMPLATES)/pre-wasmOffsetConverter.js CFLAGS_WASM+=--pre-js $(TEMPLATES)/pre-wasmMemory.js -CFLAGS_WASM+=-s ASYNCIFY_ADVISE=1 CFLAGS_WASM+=-O3 CFLAGS_CJS+=-s ENVIRONMENT=node CFLAGS_MJS+=-s ENVIRONMENT=node diff --git a/packages/variant-quickjs-ng-wasmfile-debug-asyncify/README.md b/packages/variant-quickjs-ng-wasmfile-debug-asyncify/README.md index e1d7cba9..5a194c53 100644 --- a/packages/variant-quickjs-ng-wasmfile-debug-asyncify/README.md +++ b/packages/variant-quickjs-ng-wasmfile-debug-asyncify/README.md @@ -88,7 +88,6 @@ Variant-specific Emscripten build flags: "--pre-js $(TEMPLATES)/pre-sourceMapJson.js", "--pre-js $(TEMPLATES)/pre-wasmOffsetConverter.js", "--pre-js $(TEMPLATES)/pre-wasmMemory.js", - "-s ASYNCIFY_ADVISE=1", "-O3" ] ``` diff --git a/packages/variant-quickjs-singlefile-browser-debug-asyncify/Makefile b/packages/variant-quickjs-singlefile-browser-debug-asyncify/Makefile index 21dab7dc..4aace500 100644 --- a/packages/variant-quickjs-singlefile-browser-debug-asyncify/Makefile +++ b/packages/variant-quickjs-singlefile-browser-debug-asyncify/Makefile @@ -92,7 +92,6 @@ CFLAGS_WASM+=--pre-js $(TEMPLATES)/pre-sourceMapJson.js CFLAGS_WASM+=--pre-js $(TEMPLATES)/pre-wasmOffsetConverter.js CFLAGS_WASM+=--pre-js $(TEMPLATES)/pre-wasmMemory.js CFLAGS_WASM+=-s SINGLE_FILE=1 -CFLAGS_WASM+=-s ASYNCIFY_ADVISE=1 CFLAGS_WASM+=-O3 diff --git a/packages/variant-quickjs-singlefile-browser-debug-asyncify/README.md b/packages/variant-quickjs-singlefile-browser-debug-asyncify/README.md index e9491173..38304e33 100644 --- a/packages/variant-quickjs-singlefile-browser-debug-asyncify/README.md +++ b/packages/variant-quickjs-singlefile-browser-debug-asyncify/README.md @@ -77,7 +77,6 @@ Variant-specific Emscripten build flags: "--pre-js $(TEMPLATES)/pre-wasmOffsetConverter.js", "--pre-js $(TEMPLATES)/pre-wasmMemory.js", "-s SINGLE_FILE=1", - "-s ASYNCIFY_ADVISE=1", "-O3" ] ``` diff --git a/packages/variant-quickjs-singlefile-cjs-debug-asyncify/Makefile b/packages/variant-quickjs-singlefile-cjs-debug-asyncify/Makefile index ceb0ed48..e5f1938e 100644 --- a/packages/variant-quickjs-singlefile-cjs-debug-asyncify/Makefile +++ b/packages/variant-quickjs-singlefile-cjs-debug-asyncify/Makefile @@ -92,7 +92,6 @@ CFLAGS_WASM+=--pre-js $(TEMPLATES)/pre-sourceMapJson.js CFLAGS_WASM+=--pre-js $(TEMPLATES)/pre-wasmOffsetConverter.js CFLAGS_WASM+=--pre-js $(TEMPLATES)/pre-wasmMemory.js CFLAGS_WASM+=-s SINGLE_FILE=1 -CFLAGS_WASM+=-s ASYNCIFY_ADVISE=1 CFLAGS_WASM+=-O3 CFLAGS_CJS+=-s ENVIRONMENT=web,worker,node diff --git a/packages/variant-quickjs-singlefile-cjs-debug-asyncify/README.md b/packages/variant-quickjs-singlefile-cjs-debug-asyncify/README.md index 6424a2ad..b99a07f5 100644 --- a/packages/variant-quickjs-singlefile-cjs-debug-asyncify/README.md +++ b/packages/variant-quickjs-singlefile-cjs-debug-asyncify/README.md @@ -77,7 +77,6 @@ Variant-specific Emscripten build flags: "--pre-js $(TEMPLATES)/pre-wasmOffsetConverter.js", "--pre-js $(TEMPLATES)/pre-wasmMemory.js", "-s SINGLE_FILE=1", - "-s ASYNCIFY_ADVISE=1", "-O3" ] ``` diff --git a/packages/variant-quickjs-singlefile-mjs-debug-asyncify/Makefile b/packages/variant-quickjs-singlefile-mjs-debug-asyncify/Makefile index eddec1fc..b2146452 100644 --- a/packages/variant-quickjs-singlefile-mjs-debug-asyncify/Makefile +++ b/packages/variant-quickjs-singlefile-mjs-debug-asyncify/Makefile @@ -92,7 +92,6 @@ CFLAGS_WASM+=--pre-js $(TEMPLATES)/pre-sourceMapJson.js CFLAGS_WASM+=--pre-js $(TEMPLATES)/pre-wasmOffsetConverter.js CFLAGS_WASM+=--pre-js $(TEMPLATES)/pre-wasmMemory.js CFLAGS_WASM+=-s SINGLE_FILE=1 -CFLAGS_WASM+=-s ASYNCIFY_ADVISE=1 CFLAGS_WASM+=-O3 CFLAGS_MJS+=-s ENVIRONMENT=node diff --git a/packages/variant-quickjs-singlefile-mjs-debug-asyncify/README.md b/packages/variant-quickjs-singlefile-mjs-debug-asyncify/README.md index 4d9a63b7..5d8e35e2 100644 --- a/packages/variant-quickjs-singlefile-mjs-debug-asyncify/README.md +++ b/packages/variant-quickjs-singlefile-mjs-debug-asyncify/README.md @@ -77,7 +77,6 @@ Variant-specific Emscripten build flags: "--pre-js $(TEMPLATES)/pre-wasmOffsetConverter.js", "--pre-js $(TEMPLATES)/pre-wasmMemory.js", "-s SINGLE_FILE=1", - "-s ASYNCIFY_ADVISE=1", "-O3" ] ``` diff --git a/packages/variant-quickjs-wasmfile-debug-asyncify/Makefile b/packages/variant-quickjs-wasmfile-debug-asyncify/Makefile index d3b9aa55..afbbc1b7 100644 --- a/packages/variant-quickjs-wasmfile-debug-asyncify/Makefile +++ b/packages/variant-quickjs-wasmfile-debug-asyncify/Makefile @@ -91,7 +91,6 @@ CFLAGS_WASM+=--pre-js $(TEMPLATES)/pre-extension.js CFLAGS_WASM+=--pre-js $(TEMPLATES)/pre-sourceMapJson.js CFLAGS_WASM+=--pre-js $(TEMPLATES)/pre-wasmOffsetConverter.js CFLAGS_WASM+=--pre-js $(TEMPLATES)/pre-wasmMemory.js -CFLAGS_WASM+=-s ASYNCIFY_ADVISE=1 CFLAGS_WASM+=-O3 CFLAGS_CJS+=-s ENVIRONMENT=node CFLAGS_MJS+=-s ENVIRONMENT=node diff --git a/packages/variant-quickjs-wasmfile-debug-asyncify/README.md b/packages/variant-quickjs-wasmfile-debug-asyncify/README.md index a9fa31e9..2a559f55 100644 --- a/packages/variant-quickjs-wasmfile-debug-asyncify/README.md +++ b/packages/variant-quickjs-wasmfile-debug-asyncify/README.md @@ -88,7 +88,6 @@ Variant-specific Emscripten build flags: "--pre-js $(TEMPLATES)/pre-sourceMapJson.js", "--pre-js $(TEMPLATES)/pre-wasmOffsetConverter.js", "--pre-js $(TEMPLATES)/pre-wasmMemory.js", - "-s ASYNCIFY_ADVISE=1", "-O3" ] ``` diff --git a/scripts/prepareVariants.ts b/scripts/prepareVariants.ts index 66d6febe..7c683b4d 100755 --- a/scripts/prepareVariants.ts +++ b/scripts/prepareVariants.ts @@ -223,7 +223,7 @@ function getCflags(targetName: string, variant: BuildVariant) { flags.push("-g2") break case SyncMode.Asyncify: - flags.push("-s ASYNCIFY_ADVISE=1") + // flags.push("-s ASYNCIFY_ADVISE=1") flags.push( // # Need to use -O3 - otherwise ASYNCIFY leads to stack overflows (why?) "-O3",