Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Monitoring #60

Open
webtekindo opened this issue Oct 27, 2020 · 10 comments · May be fixed by #145
Open

Performance Monitoring #60

webtekindo opened this issue Oct 27, 2020 · 10 comments · May be fixed by #145
Labels
enhancement New feature or request hacktoberfest

Comments

@webtekindo
Copy link

Is there any plan to be able to use https://docs.sentry.io/product/performance/getting-started/ with this extension? Thank you.

@indykoning indykoning added the enhancement New feature or request label Oct 28, 2020
@indykoning
Copy link
Member

That is not in the planning yet, but is is a great feature request! 😄

I have put it on the planning, in the meantime PRs are always welcome 🙂

@peterjaap
Copy link
Contributor

@webtekindo what should we add for this? As far as I can see, you just have to add 'traces_sample_rate' => 1.0 to your env.php file?

@salmino
Copy link

salmino commented Feb 22, 2021

@webtekindo what should we add for this? As far as I can see, you just have to add 'traces_sample_rate' => 1.0 to your env.php file?

@peterjaap does the plugin pass the traces_sample_rate parameter onto Sentry SDK?

@peterjaap
Copy link
Contributor

peterjaap commented May 17, 2022

@salmino you're right. It does not.

But with #90, you can easily enable the performance monitoring to test it. I'm running a test now, if it's successful, I'll create a PR to add it to this extension.

I've created an observer that does this;

$observer->getEvent()->getConfig()->setTracesSampleRate(1.0);

Or you could use the sampler;

$observer->getEvent()->getConfig()->setTracesSampler(function (\Sentry\Tracing\SamplingContext $context): float {
    return 1.0;
});

@peterjaap
Copy link
Contributor

If you run it in production and especially if you have a high sample rate, please use Relay.

@peterjaap
Copy link
Contributor

I guess this doesn't do anything since we should probably find a way to create these "Transactions" they're speaking of. Now, this extension only fires when an actual exception is being thrown.

@peterjaap
Copy link
Contributor

Ah, here's some more info on how to create those transactions; https://docs.sentry.io/platforms/php/performance/instrumentation/custom-instrumentation/

@peterjaap
Copy link
Contributor

Maybe we could get some inspiration from https://github.com/yireo/Yireo_NewRelic2

@barryvdh
Copy link
Contributor

barryvdh commented Nov 2, 2022

Proof of concept: #106

@metalc0der
Copy link

Is performance monitoring working?

@rommelfreddy rommelfreddy linked a pull request Aug 7, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants