-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(connector): introduce feature_matrix
api to coinbase, iatapay, nexixpay and square
#7339
base: main
Are you sure you want to change the base?
Conversation
Changed Files
|
04f14a8
to
53b522b
Compare
53b522b
to
5097104
Compare
0a070f6
to
d47a0b5
Compare
7f0f983
to
22c3cdb
Compare
…is enabled (core does not call validation if feature matrix is implemented)
22c3cdb
to
83fe8d7
Compare
enums::PaymentMethodType::UpiCollect, | ||
PaymentMethodDetails { | ||
mandates: common_enums::FeatureStatus::NotSupported, | ||
refunds: common_enums::FeatureStatus::Supported, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refunds are not supported for crypto payments. Why is this marked as supported?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i believe, you meant this: Does Iatapay support refunds for UpiCollect. Please check Iatapay docs?
yes. iatapay does support refunds. but not via hyperswitch. this can only be verified via the stripe compatibility layer.
enums::PaymentMethodType::UpiIntent, | ||
PaymentMethodDetails { | ||
mandates: common_enums::FeatureStatus::NotSupported, | ||
refunds: common_enums::FeatureStatus::Supported, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refunds are not supported for crypto payments. Why is this marked as supported?
enums::PaymentMethodType::Ideal, | ||
PaymentMethodDetails { | ||
mandates: common_enums::FeatureStatus::NotSupported, | ||
refunds: common_enums::FeatureStatus::Supported, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does Iatapay support refunds for Ideal. Please check Iatapay docs?
enums::PaymentMethodType::LocalBankRedirect, | ||
PaymentMethodDetails { | ||
mandates: common_enums::FeatureStatus::NotSupported, | ||
refunds: common_enums::FeatureStatus::Supported, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does Iatapay support refunds for Local Bank Redirect. Please check Iatapay docs?
enums::PaymentMethodType::DuitNow, | ||
PaymentMethodDetails { | ||
mandates: common_enums::FeatureStatus::NotSupported, | ||
refunds: common_enums::FeatureStatus::Supported, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does Iatapay support refunds for Duit Now. Please check Iatapay docs?
enums::PaymentMethodType::Fps, | ||
PaymentMethodDetails { | ||
mandates: common_enums::FeatureStatus::NotSupported, | ||
refunds: common_enums::FeatureStatus::Supported, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does Iatapay support refunds for Fps. Please check Iatapay docs?
enums::PaymentMethodType::PromptPay, | ||
PaymentMethodDetails { | ||
mandates: common_enums::FeatureStatus::NotSupported, | ||
refunds: common_enums::FeatureStatus::Supported, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does Iatapay support refunds for PromptPay. Please check Iatapay docs?
enums::PaymentMethodType::VietQr, | ||
PaymentMethodDetails { | ||
mandates: common_enums::FeatureStatus::NotSupported, | ||
refunds: common_enums::FeatureStatus::Supported, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does Iatapay support refunds for Viet QR. Please check Iatapay docs?
Type of Change
Description
this pr introduces feature_matrix api to 4 more connectors and in addition to that, pm filters also have been updated.
have written many scripts to verify the pm_filters and are attached in the issue
Additional Changes
Motivation and Context
me.
How did you test it?
tested by making a request to the feature matrix endpoint:
request:
response:
Checklist
cargo +nightly fmt --all
cargo clippy --all-features --all-targets -- -D warnings