Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(analytics): implement currency conversion to power multi-currency aggregation #6416

Open
maverox opened this issue Oct 23, 2024 · 0 comments · May be fixed by #6418
Open

feat(analytics): implement currency conversion to power multi-currency aggregation #6416

maverox opened this issue Oct 23, 2024 · 0 comments · May be fixed by #6418
Assignees
@maverox
Labels
A-Analytics C-feature Category: Feature request or enhancement Rust Pull requests that update Rust code

Comments

@maverox
Copy link

maverox commented Oct 23, 2024

Current Behaviour

The total amount calculated for all payment analytics buckets related to amounts is incorrect because currency conversion is not being applied before summing the values. As a result, amounts in different currencies are being added together, leading to an inaccurate total.

Proposed Changes

  • introduce <AMOUNT_RELATED_FIELD>_in_usd fields to convert and store value in USD
  • introduce total_in_usd to store the total value in usd
  • Generally provide currency_conversion facility to metrics function for other future use cases
@maverox maverox added A-Analytics C-feature Category: Feature request or enhancement Rust Pull requests that update Rust code labels Oct 23, 2024
@maverox maverox self-assigned this Oct 23, 2024
@maverox maverox linked a pull request Oct 23, 2024 that will close this issue
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maverox maverox

Labels
A-Analytics C-feature Category: Feature request or enhancement Rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
1 participant
@maverox