Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SC double check #64

Open
frugge opened this issue Dec 2, 2019 · 2 comments
Open

SC double check #64

frugge opened this issue Dec 2, 2019 · 2 comments

Comments

@frugge
Copy link
Contributor

frugge commented Dec 2, 2019

Please take a look to our edits on SC made into arbitration.sol file referring to this commit f270a4c

@0xlyd
Copy link
Contributor

0xlyd commented Dec 3, 2019

hey @frugge can you please describe a bit the method added so that @tyagishuchi1 can review the code?

For the future at least on the SC part let's go with a PR it will keep things organized, thanks

@frugge
Copy link
Contributor Author

frugge commented Dec 3, 2019

In order to fully implement withdraw at the end of the dispute (escrowed amount + reward), I needed to receive some additional information.

For this purpose I added:

  • the "canWithdraw ()" method that returns:

    • 'hasWithdrawn' which is a Boolean field that indicates whether the current user has made the withdrawal
    • 'Payout' a numeric field indicating the amount due to the current user.
  • the "canClaimReward ()" method which returns two fields:

    • 'status' which can take 4 values:
          0: Reward not due;
          1: Reward still not claimable (the 'vote_lookup' period has not yet passed since the end of the dispute);
          2: Reward can be claimed;
          3: The reward has already been claimed.
    • 'amount' which is the total of the reward due to the current user.

All this edit are present only into open layer.
@lucaydaniel @tyagishuchi1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants