Update jetstream docs #1038
Update jetstream docs #1038
Conversation
zonca
force-pushed
the
update-jetstream-docs
branch
from
81a600c to
b9f7a6e
Compare
|
not sure why |
|
Fixes #971 |
|
@julianpistorius rewrote it after your feedback, I think it is just better to avoid the boot script entirely. The user has to ssh into the instance anyway to setup HTTPS, so let's just do that. The format of the init script is quite awkward, too easy to mess it up. |
zonca
force-pushed
the
update-jetstream-docs
branch
2 times, most recently
from
8a38ee7 to
a4858da
Compare
for more information, see https://pre-commit.ci
…stream installation guide
for more information, see https://pre-commit.ci
|
Makes sense! Thank you @zonca. I'll have another look. |
|
@julianpistorius waiting for your second review before marking this as ready |
There was a problem hiding this comment.
Apologies for the delay @zonca!
I made some suggestions. I haven't tested them locally yet. 🤞
Generally I fixed a few links and clarified wording.
My only remaining concerns are that according to the contributing guide:
(Tutorials) should cross-link a lot to other parts of the documentation, avoid forcing the user to learn to SSH if possible & have lots of screenshots.
- We're forcing the user to learn SSH
- We don't have any screenshots anymore
SSH: We could tell them where the passphrase is, and/or point them at the Web Shell.
Screenshots: I made a few screenshots which are in my branch, and still show in my closed PR's files if you want to steal those.
Let me know what you think. Thanks again!
Co-authored-by: Julian Pistorius <[email protected]>
for more information, see https://pre-commit.ci
Co-authored-by: Julian Pistorius <[email protected]>
Co-authored-by: Julian Pistorius <[email protected]>
Co-authored-by: Julian Pistorius <[email protected]>
Co-authored-by: Julian Pistorius <[email protected]>
Co-authored-by: Julian Pistorius <[email protected]>
for more information, see https://pre-commit.ci
Co-authored-by: Julian Pistorius <[email protected]>
|
Thank you @zonca! Is it ready for another look? |
|
Yes, the only leftover was one thing that I could not apply using the GitHub interface |
1 similar comment
|
Yes, the only leftover was one thing that I could not apply using the GitHub interface |
|
Maybe you can do a pull request towards my Branch in my own repository so I can just merge it in? |
|
ok @julianpistorius I added your last suggestion, please give it a quick review so we can mark it as ready for review by the project maintainers. |
2 participants
Updated the tutorial to deploy on Jetstream 2, tested on Ubuntu 24.04.
I'll have the Jetstream team review this first, then I'll mark this ready for your review.