Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document ways to make sure our state is always synchronized #4

Open
yuvipanda opened this issue Dec 24, 2018 · 0 comments
Open

Document ways to make sure our state is always synchronized #4

yuvipanda opened this issue Dec 24, 2018 · 0 comments

Comments

@yuvipanda
Copy link
Collaborator

We've several flags like running and _killed that must be synchronized with the real state of the process we are supervising. We potentially lose control with every await call, so need to be careful where we set the flags. Also need to realize that the flags could be set to something else when we come back from the await call.

I suspect we should count lines between await calls as something similar to critical sections and set our flags there. And not assume any flags set before an await are the same after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant