Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing default branch makes all tests fail #283

Open
jdmansour opened this issue Nov 11, 2022 · 1 comment
Open

Changing default branch makes all tests fail #283

jdmansour opened this issue Nov 11, 2022 · 1 comment
Labels

Comments

@jdmansour
Copy link
Contributor

Bug description

If you have changed the default branch name on your computer, as git init now suggests, all nbgitpuller tests fail.

How to reproduce

# The following fails:
git config --global init.defaultBranch main
python -m pytest tests/test_gitpuller.py

# This works again:
git config --global init.defaultBranch master
python -m pytest tests/test_gitpuller.py

I think this is because repohelpers.py hardcodes the master branch name, but when creating test repos doesn't specify a name. I'll look into it next week, it should not be too hard.

@jdmansour jdmansour added the bug label Nov 11, 2022
@consideRatio
Copy link
Member

Ah nice work figuring that out!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants