Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the file browser default column width #7476

Open
jtpio opened this issue Oct 14, 2024 · 0 comments
Open

Fix the file browser default column width #7476

jtpio opened this issue Oct 14, 2024 · 0 comments

Comments

@jtpio
Copy link
Member

jtpio commented Oct 14, 2024

In #7423 we tried to make the file browser default column width stable.

But it looks like they are not by default, as reloading the page several times in a row would yield different widths for the columns.

The UI tests have added a maxDiffPixels to get around that for now just to be able to get a release out, here:

expect(await page.screenshot()).toMatchSnapshot('tree.png', {
maxDiffPixels: 500,
});

and here:

expect(await page.screenshot()).toMatchSnapshot('top-hidden.png', {
maxDiffPixels: 500,
});

But we should clearly undo that change because the file browser should always open the same way.

cc @krassowski @JasonWeill I would appreciate if you could help have a look at this since you both worked on the upstream feature in JupyterLab. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants