Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests should generate the wheel and then use it to install for the tests #64

Open
ianhi opened this issue Mar 12, 2021 · 0 comments
Open

Tests should generate the wheel and then use it to install for the tests #64

ianhi opened this issue Mar 12, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ianhi
Copy link
Contributor

ianhi commented Mar 12, 2021

This will better emulate then end user experience, as well as detect any issue with the build.

For example on ipywidgets the tests are run by installing the previously generated file:
https://github.com/jupyter-widgets/ipywidgets/blob/61e8887fa0523c6b861a4fc6b2467678c5d699e5/.github/workflows/tests.yml#L115-L118
@ianhi ianhi added enhancement New feature or request good first issue Good for newcomers labels Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ianhi