Skip to content

Commit 02d81f5

Browse files
Fix ignoring empty update (#111)
* Add test for non-empty update * Add fix for ignoring empty update
1 parent f5a9104 commit 02d81f5

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

src/doc.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ impl Doc {
116116
pub fn observe(&mut self, py: Python<'_>, f: PyObject) -> PyResult<Py<Subscription>> {
117117
let sub = self.doc
118118
.observe_transaction_cleanup(move |txn, event| {
119-
if event.before_state != event.after_state {
119+
if !event.delete_set.is_empty() || event.before_state != event.after_state {
120120
Python::with_gil(|py| {
121121
let event = TransactionEvent::new(event, txn);
122122
if let Err(err) = f.call1(py, (event,)) {

tests/test_doc.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -191,3 +191,15 @@ def test_empty_update():
191191
doc["text"]
192192
# empty updates should not emit an event
193193
assert not events
194+
195+
196+
def test_not_empty_update():
197+
doc = Doc()
198+
doc["text"] = text = Text()
199+
events = []
200+
sub = doc.observe(partial(callback, events)) # noqa: F841
201+
202+
text += "helloo"
203+
events.clear()
204+
del text[5]
205+
assert events

0 commit comments

Comments
 (0)