Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Id based routing #4

Open
tonila opened this issue Dec 13, 2018 · 2 comments
Open

Id based routing #4

tonila opened this issue Dec 13, 2018 · 2 comments

Comments

@tonila
Copy link

tonila commented Dec 13, 2018

Hi,

I noticed, this library does not support id based routing.

Currently, when this library calls e.g. Querybuilder->save, it calls cosmos REST API 3 times.

  1. listDatabases to get database _rid
  2. listCollections to get collection _rid
  3. and finally either replaceDocument or createDocument to save document

This becomes unnecessary, when id based routing is used.

I have working implementation at my fork, altough not completely implemented nor tested:
https://github.com/tonila/cosmosdb

Feel free to check it out.

@jupitern
Copy link
Owner

jupitern commented Jan 8, 2019

Hi,
I haven't had the time to check your code about id based routing but the last changes I made resolve the 3 requests issue.

@jupitern
Copy link
Owner

Next release will look into id based routing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants