Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Configuration Options for Jupiter Terminal Settings Modal #123

Open
kizmt opened this issue Nov 4, 2024 · 1 comment
Open

Comments

@kizmt
Copy link

kizmt commented Nov 4, 2024

Feature Request: Additional Configuration Options for Jupiter Terminal Settings Modal

Overview

Request to expose additional configuration options (priority fees and dynamic slippage) in the IInit interface when using Jupiter Terminal.

Current Type Definition

Currently, the IInit interface handles slippage configuration like this:

export interface IInit {
// ... other props
formProps?: FormProps;
/** Use user's slippage instead of initialSlippageBps, defaults to true */
useUserSlippage?: boolean;
/** TODO: NOT Supported yet, presets of slippages, defaults to [0.1, 0.5, 1.0] */
slippagePresets?: number[];
// ... other props
}

Desired Type Definitions

Would like to extend FormProps to include:

export interface IInit {
// Existing props...
formProps?: FormProps;
useUserSlippage?: boolean;
slippagePresets?: number[];
// New configuration options
useDynamicSlippage?: boolean;
maxDynamicSlippageBps?: number;
defaultSlippageMode?: "DYNAMIC" | "FIXED";
// Priority fee configuration
usePriorityFees?: boolean;
defaultPriorityFee?: number;
defaultPriorityMode?: "MAX" | "EXACT";
defaultPriorityLevel?: "FAST" | "TURBO" | "ULTRA";
}

Use Cases

  1. Need to set higher priority fee levels by default for better transaction reliability
  2. Want to start users with Turbo/Ultra mode enabled to ensure faster transaction processing
  3. Need to set maximum dynamic slippage limits for user protection

Current Workarounds

Currently unable to configure these settings during initialization, forcing users to manually adjust settings after the terminal loads.

Questions

  1. Would these be better as top-level IInit properties or should they be nested under a new config object?
  2. Are there plans to expose more configuration options for the CDN implementation?

Let me know if you need any additional information!

@KoenRijpstra
Copy link

@worlddlckgh gm! Could you take a look at this? We’re planning to integrate swapping into the new XRAY explorer and want to ensure users have an optimal swapping experience by default. Let me know if you need more information or have any questions. Greetings from the Helius team!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants