Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore records based on type or name #17

Open
jungaretti opened this issue Nov 27, 2022 · 1 comment
Open

Ignore records based on type or name #17

jungaretti opened this issue Nov 27, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@jungaretti
Copy link
Owner

jungaretti commented Nov 27, 2022

Bacon needs to offer the option to ignore records based on their type or name. Porkbun recently updated their API to return NS nameserver records. Furthermore, they rotate _acme-challenge.example.com records regularly.

Output of bacon deploy

Would delete 6 records:
- {263350200 jungaretti.com NS curitiba.porkbun.com 86400  }
- {263350203 jungaretti.com NS fortaleza.porkbun.com 86400  }
- {263350205 jungaretti.com NS maceio.porkbun.com 86400  }
- {263350206 jungaretti.com NS salvador.porkbun.com 86400  }
- {263350208 _acme-challenge.jungaretti.com TXT nStUIY7ccq-47CEgzHa8rBnfirueLxVRaLjpXcdinSg 600  }
- {263350209 _acme-challenge.jungaretti.com TXT XN05LMcknvIkobS1q3GF4m11zL2dtVT7T043K_zxAyc 600  }
Would create 2 records:
- { _acme-challenge.jungaretti.com TXT Kb6-nJirHoqvIqzbzKklBaXrbmqxbLav77qO0o1BFPY 600  }
- { _acme-challenge.jungaretti.com TXT J4Qs_IAv-pH5RMFZ64pI50SL-t21Tq6WHkycp6BExjc 600  }
Mock deployment complete

This is bad. Bacon wants to delete the 4 NS records and revert the _acme-challenge.jungaretti.com records.

@jungaretti jungaretti added the bug Something isn't working label Nov 27, 2022
@jungaretti jungaretti added this to the v1.1 milestone Nov 27, 2022
@jungaretti
Copy link
Owner Author

jungaretti commented Dec 4, 2022

This is fixed in v1.1. It's not a generic fix, but it unblocks Bacon: https://github.com/jungaretti/bacon/blob/v1.1/pkg/providers/porkbun/api/api.go#L91-L113

@jungaretti jungaretti removed this from the v1.1 milestone Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant