Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to use as jj merge tool as well #6

Open
garymjr opened this issue Jul 26, 2024 · 3 comments
Open

Add ability to use as jj merge tool as well #6

garymjr opened this issue Jul 26, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@garymjr
Copy link

garymjr commented Jul 26, 2024

Hey @julienvincent, thanks for this plugin it works great. I was wondering if you had considered extending this to support commands like ``jj resolve` as well?

@julienvincent
Copy link
Owner

Hey, glad you like it!

Yes I do plan to add a conflict resolution component when I get some time.

Should be relatively simple to add on top of what's been built here!

@julienvincent
Copy link
Owner

Also for those interested there is https://github.com/rafikdraoui/jj-diffconflicts - which I'd like to take some inspiration from.

I don't entirely like the way it's done in that plugin but I think some of the core ideas are good.

I like that there is a history view with a three-way diff. This will make interpreting a diff much easier.

I think I'd maybe want some way to select lines from left and right (using the selection tools from hunk.nvim) and then a way to edit the final result.

Not yet sure how this will work.

@garymjr
Copy link
Author

garymjr commented Jul 28, 2024

Awesome! Thanks for pointing out that plugin as well. I'm fairly new to jujutsu so I'm still finding all the extra tooling around it.

@julienvincent julienvincent added the enhancement New feature or request label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants