Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate that generated code matches included schemas #1164

Open
james-garner-canonical opened this issue Oct 16, 2024 · 0 comments
Open

Validate that generated code matches included schemas #1164

james-garner-canonical opened this issue Oct 16, 2024 · 0 comments
Labels
area/tests Updates the tests or test infrastructure hint/3.x going on main branch kind/wishlist requested feature priority/normal normal priority

Comments

@james-garner-canonical
Copy link
Contributor

james-garner-canonical commented Oct 16, 2024

Description

Juju validates on PRs that the schema file is up to date.

python-libjuju validates on PRs that generated code matches the manually maintained dictionaries of supported and not-yet-supported facade versons.

One missing link here is that python-libjuju should also validate that the current generated code matches the current schema files. This would both validate that make client has been run after checking in a schema file, which will be helpful for making sure the proper process is followed for future python-libjuju releases, and provide some validation for the code generation itself, which will be helpful if we every try to refactor it.

Code I'd Like to Run

pytest tests/validate/test_facades.py::test_generated_code_matches_schemas
@james-garner-canonical james-garner-canonical added kind/wishlist requested feature hint/3.x going on main branch priority/normal normal priority area/tests Updates the tests or test infrastructure labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tests Updates the tests or test infrastructure hint/3.x going on main branch kind/wishlist requested feature priority/normal normal priority
Projects
None yet
Development

No branches or pull requests

1 participant