Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve unit test coverage for juju.model.Model.deploy #1162

Open
james-garner-canonical opened this issue Oct 16, 2024 · 0 comments
Open

Improve unit test coverage for juju.model.Model.deploy #1162

james-garner-canonical opened this issue Oct 16, 2024 · 0 comments
Labels
area/tests Updates the tests or test infrastructure hint/3.x going on main branch kind/wishlist requested feature priority/low low priority

Comments

@james-garner-canonical
Copy link
Contributor

Description

deploy does not appear to be well covered by unit tests, if at all. There are a bunch of tricky arguments, like storage constraints, that could perhaps be checked in unit tests, though the appropriate level to mock or fake at is not immediately clear to me.

See: #1105 (comment)

It would be nice to run coverage and get an idea of what is and isn't covered by unit tests. We could add a tox environment for it.

Urgency

Casually wishlisting

Code I'd Like to Run

...
@james-garner-canonical james-garner-canonical added priority/low low priority kind/wishlist requested feature hint/3.x going on main branch area/tests Updates the tests or test infrastructure labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/tests Updates the tests or test infrastructure hint/3.x going on main branch kind/wishlist requested feature priority/low low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@james-garner-canonical