Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The go-nfs-client library supports configuring the pull list cache size #5387

Open
zhengp570 opened this issue Dec 17, 2024 · 2 comments
Open
Assignees
Labels
kind/feature New feature or request

Comments

@zhengp570
Copy link

What would you like to be added:
The go-nfs-client library supports configuring the pull list cache size

Why is this needed:

When calling the List(...) function in pkg/object/nfs.go, it was found that only 20 files could be pulled at a time. With a large number of files, this would inevitably require many trips back and forth. In my environment, testing the pull of 10,000 files took 8 seconds. It was discovered that the default buffer size was only 512 bytes. If the buffer size in the go-nfs-client library is increased, the time can be reduced to 4 seconds, which is a 50% performance improvement. Can the buffer be set to be dynamically adjustable?

@zhengp570 zhengp570 added the kind/feature New feature or request label Dec 17, 2024
@anysql
Copy link
Contributor

anysql commented Dec 18, 2024

We just reference the client library statically, usually will not modify the code.

Just found that there are nfs4 version client library, which the default value of DirCount & MaxCount is 128 * 1024.

We will take a look at the newer version nfs client.

@zhengp570
Copy link
Author

@anysql Thank you for your answer. By the way, since you've provided an NFS library, why not a CIFS library? Do you have any good CIFS libraries to recommend?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants