Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using cargo-make #1040

Open
jayvdb opened this issue Sep 9, 2024 · 4 comments
Open

Switch to using cargo-make #1040

jayvdb opened this issue Sep 9, 2024 · 4 comments

Comments

@jayvdb
Copy link
Contributor

jayvdb commented Sep 9, 2024

Would you be interested in me replacing test.sh with a Makefile.toml

https://github.com/sagiegurari/cargo-make

I can do all the CI stuff to make this work.

@juhaku
Copy link
Owner

juhaku commented Sep 9, 2024

Why not, I have been actually weighting upon that or justfile or just plain make. 😆 But I haven't got anywhere with that choice. Sure if you want to set things up that would be great. That test file get's anyway quite cumbersome to maintain. One thing to add is probably coverage as well at somepoint but haven't really got to it.

@juhaku
Copy link
Owner

juhaku commented Sep 9, 2024

Like what ever is the scripts could be migrated to the either of those options. And cargo make is one feasible option.

@jayvdb
Copy link
Contributor Author

jayvdb commented Sep 9, 2024

Both cargo-make and just are supported by https://github.com/taiki-e/install-action/blob/main/TOOLS.md , which speeds up the CI installing of the tool.

just has more stars - I havent used that yet, so I will try it first.

@juhaku
Copy link
Owner

juhaku commented Sep 9, 2024

Yeah, sure thing, for what I understand the justfile basically 60 % makefile and then the rest is build on top of it to enhance the quirks of old fashioned makefile to give smooth command running experience.

For example the acitx-web is using justfile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants