Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create package #7

Open
totallyunknown opened this issue Jun 24, 2017 · 2 comments
Open

Create package #7

totallyunknown opened this issue Jun 24, 2017 · 2 comments

Comments

@totallyunknown
Copy link

I think it make sense to make this as a package, so we can use it as a mock for unit testing in kube2iam. What do you think?

@jtblin
Copy link
Owner

jtblin commented Jun 25, 2017

I definitely use the docker image to be able to test locally with minikube and we could use it for some kind of end to end tests but I think that would be pretty hard to setup and maintain. I'm looking at increasing unit test coverage first for which I think, I'd just use unit level mocks rather than running aws-mock-metadata. But I'm opened to suggestion, did you have something else in mind?

@CpuID
Copy link
Collaborator

CpuID commented Feb 28, 2018

#10 adds a lot of mocked test coverage, which will get merged sometime shortly.

@totallyunknown can you elaborate on what the testing topology might look like with kube2iam, the way you vision things currently? I can see both sides of the argument (with limited exposure right now), re moving the source code into a subdirectory that can be used as a package, vs using a Docker based aws-mock-metadata to expose the mocks where required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants