-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
isIn(Collection) not matching Integers #1227
Comments
m37r
added a commit
to m37r/tablesaw
that referenced
this issue
Aug 18, 2023
ccleva
added a commit
to tlabs-data/tablesaw
that referenced
this issue
Dec 14, 2024
ccleva
pushed a commit
to tlabs-data/tablesaw
that referenced
this issue
Dec 14, 2024
(cherry picked from commit 6d07355)
1 task
ccleva
added a commit
to tlabs-data/tablesaw
that referenced
this issue
Dec 14, 2024
ccleva
pushed a commit
to tlabs-data/tablesaw
that referenced
this issue
Dec 14, 2024
(cherry picked from commit 6d07355)
Hi @m37r. This issue has been fixed using your PR in the new maintenance release from the maintenance fork. See this discussion for details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For a given IntColumn, only the
isIn(int...)
method produces the expected results. TheisIn(Collection)
method inherited from NumericColumn matches actually contained numbers only when they are entered as Doubles into the query collection.To test:
I think this is due to
NumericColumn.isIn(Collection)
usingCollection.contains
for matching against Double-converted content cells. I might even produce a fix.The text was updated successfully, but these errors were encountered: