Skip to content

[Bug] jsx-no-constructed-context-values empty schema is incorrect #3580

Closed as not planned
@Dimava

Description

@Dimava

https://github.com/jsx-eslint/eslint-plugin-react/blob/747fad0e06e73155616df62575626f7953260dec/lib/rules/jsx-no-constructed-context-values.js#LL141C13-L141C15

jsx-no-constructed-context-values empty schema should be [], but it's {}

This leads to incorrect rule type generation by https://github.com/Shinigami92/eslint-define-config

export interface JsxNoConstructedContextValuesRule {
  /**
   * Disallows JSX context provider values from taking values that will cause needless rerenders.
   *
   * @see [jsx-no-constructed-context-values](https://github.com/jsx-eslint/eslint-plugin-react/tree/master/docs/rules/jsx-no-constructed-context-values.md)
   */
  'react/jsx-no-constructed-context-values': Rule<
    [
      RuleLevel,
      ...{
        [k: string]: any; // <-- `...{}`, explected `...[]` (i.e. no settings)
      },
    ]
  >;
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions