Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: transloco-keys-manager does not extract text from the attribute directive #145

Open
1 task done
votdev opened this issue Oct 30, 2022 · 0 comments
Open
1 task done
Labels
bug Something isn't working good first issue Good for newcomers PRs welcome

Comments

@votdev
Copy link

votdev commented Oct 30, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Is this a regression?

No

Current behavior

The transloco-keys-manager tool seems not to extract text from the attribute directive. The structural directive works, but the attribute directive is prefered because of it's simplicity.

This is not working:

<span transloco="Logged in as {{ username }}"></span>

This is working:

<span *transloco="let t">
  {{ t('Logged in as {{ username }}') }}
</span>

Expected behavior

I expect that the text Logged in as {{ username }} is extracted when using the attribute directive.

Please provide a link to a minimal reproduction of the bug

openmediavault/openmediavault#1329

Transloco Config

module.exports = {
  rootTranslationsPath: 'src/assets/i18n/',
  langs: ['openmediavault-workbench'],
  keysManager: {
    fileFormat: 'pot',
    marker: 'gettext',
    defaultValue: ''
  }
};

Debug Logs

No response

Please provide the environment you discovered this bug in

Transloco: 3.2.0
Transloco Keys Manager: 3.4.2
Angular: 12
Node: v16.18.0
Package Manager: npm 8.12.1
OS: Ubuntu/Debian

Additional context

No response

I would like to make a pull request for this bug

No

@shaharkazaz shaharkazaz added bug Something isn't working good first issue Good for newcomers PRs welcome labels Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers PRs welcome
Projects
None yet
Development

No branches or pull requests

2 participants