Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eof/prcomp scale argument is hardcoded #6

Open
troyhill opened this issue Apr 15, 2021 · 0 comments
Open

eof/prcomp scale argument is hardcoded #6

troyhill opened this issue Apr 15, 2021 · 0 comments

Comments

@troyhill
Copy link

I noticed that the scale. argument passed to wql::eof is not used in the function. I think that argument is intended to be used on line 89, but the scale argument in the prcomp call is hard-coded as TRUE (pr1 <- prcomp(x, scale.=TRUE)) instead of pr1 <- prcomp(x, scale.=scale.)

Thank you for the excellent package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant