Skip to content

Commit ae5bb5b

Browse files
committed
Fix incorrect use of "it's" and "its", adjust wording
1 parent 703fedd commit ae5bb5b

File tree

15 files changed

+35
-35
lines changed

15 files changed

+35
-35
lines changed

common/os_calls.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -399,7 +399,7 @@ g_tcp_set_keepalive(int sck)
399399

400400
/*****************************************************************************/
401401
/* returns a newly created socket or -1 on error */
402-
/* in win32 a socket is an unsigned int, in linux, its an int */
402+
/* in win32 a socket is an unsigned int, in linux, it's an int */
403403
int APP_CC
404404
g_tcp_socket(void)
405405
{

docs/man/xrdp.ini.5

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ This option sets the logging level for syslog. It can have the same values of \f
158158
.SH "CHANNELS"
159159
The Remote Desktop Protocol supports several channels, which are used to transfer additional data like sound, clipboard data and others.
160160
Channel names not listed here will be blocked by \fBxrdp\fP.
161-
Not all channels are supported in all cases, so setting a value to \fItrue\fP is a pre-requisite, but does not force it's use.
161+
Not all channels are supported in all cases, so setting a value to \fItrue\fP is a pre-requisite, but does not force its use.
162162
.br
163163
Channels can also be enabled or disabled on a per connection basis by prefixing each setting with \fBchannel.\fP in the channel section.
164164

faq-general.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,17 @@ General FAQ
22

33
Q. What is RDP?
44

5-
A. RDP stands for Remote Desktop Protocol. Its the protocol used by Windows
5+
A. RDP stands for Remote Desktop Protocol. It's the protocol used by Windows
66
terminal servers to talk to the terminal server clients.
77

88

99
Q. What is xrdp?
1010

11-
A. xrdp, usually spell lower case, is as open source implementation of the RDP
12-
protocol.
11+
A. xrdp, usually spelled in lower case, is as open source implementation of the
12+
RDP protocol.
1313

1414

15-
Q. I can't get it to compile in Ubuntu. What can I do?
15+
Q. I can't get xrdp to compile in Ubuntu. What can I do?
1616

1717
A. See faq-compile.txt.
1818

libxrdp/libxrdp.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -485,12 +485,12 @@ libxrdp_send_bitmap(struct xrdp_session *session, int width, int height,
485485

486486
if (j > 32768)
487487
{
488-
g_writeln("error, decompressed size too big, its %d", j);
488+
g_writeln("error, decompressed size too big: %d bytes", j);
489489
}
490490

491491
if (bufsize > 8192)
492492
{
493-
g_writeln("error, compressed size too big, its %d", bufsize);
493+
g_writeln("error, compressed size too big: %d bytes", bufsize);
494494
}
495495

496496
s->p = s->end;
@@ -504,7 +504,7 @@ libxrdp_send_bitmap(struct xrdp_session *session, int width, int height,
504504

505505
if (total_bufsize > 8192)
506506
{
507-
g_writeln("error, total compressed size too big, its %d",
507+
g_writeln("error, total compressed size too big: %d bytes",
508508
total_bufsize);
509509
}
510510
}

libxrdp/xrdp_mcs.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1023,7 +1023,7 @@ xrdp_mcs_send(struct xrdp_mcs *self, struct stream *s, int chan)
10231023

10241024
if (len > 8192 * 2)
10251025
{
1026-
g_writeln("error in xrdp_mcs_send, size too big, its %d", len);
1026+
g_writeln("error in xrdp_mcs_send, size too big: %d bytes", len);
10271027
}
10281028

10291029
//if (len > max_len)

libxrdp/xrdp_orders.c

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -236,15 +236,15 @@ xrdp_orders_check(struct xrdp_orders *self, int max_size)
236236
size = (int)(self->out_s->p - self->order_count_ptr);
237237
if (size < 0)
238238
{
239-
g_writeln("error in xrdp_orders_check, size too small, its %d", size);
239+
g_writeln("error in xrdp_orders_check, size too small: %d bytes", size);
240240
return 1;
241241
}
242242
if (size > max_packet_size)
243243
{
244244
/* this suggests someone calls this function without passing the
245245
correct max_size so we end up putting more into the buffer
246246
than we indicate we can */
247-
g_writeln("error in xrdp_orders_check, size too big, its %d", size);
247+
g_writeln("error in xrdp_orders_check, size too big: %d bytes", size);
248248
/* We where getting called with size already greater than
249249
max_packet_size
250250
Which I suspect was because the sending of text did not include
@@ -507,7 +507,7 @@ xrdp_orders_rect(struct xrdp_orders *self, int x, int y, int cx, int cy,
507507

508508
if (rect != 0)
509509
{
510-
/* if clip is present, still check if its needed */
510+
/* if clip is present, still check if it's needed */
511511
if (x < rect->left || y < rect->top ||
512512
x + cx > rect->right || y + cy > rect->bottom)
513513
{
@@ -678,7 +678,7 @@ xrdp_orders_screen_blt(struct xrdp_orders *self, int x, int y,
678678

679679
if (rect != 0)
680680
{
681-
/* if clip is present, still check if its needed */
681+
/* if clip is present, still check if it's needed */
682682
if (x < rect->left || y < rect->top ||
683683
x + cx > rect->right || y + cy > rect->bottom)
684684
{
@@ -870,7 +870,7 @@ xrdp_orders_pat_blt(struct xrdp_orders *self, int x, int y,
870870

871871
if (rect != 0)
872872
{
873-
/* if clip is present, still check if its needed */
873+
/* if clip is present, still check if it's needed */
874874
if (x < rect->left || y < rect->top ||
875875
x + cx > rect->right || y + cy > rect->bottom)
876876
{
@@ -1087,7 +1087,7 @@ xrdp_orders_dest_blt(struct xrdp_orders *self, int x, int y,
10871087

10881088
if (rect != 0)
10891089
{
1090-
/* if clip is present, still check if its needed */
1090+
/* if clip is present, still check if it's needed */
10911091
if (x < rect->left || y < rect->top ||
10921092
x + cx > rect->right || y + cy > rect->bottom)
10931093
{
@@ -1258,7 +1258,7 @@ xrdp_orders_line(struct xrdp_orders *self, int mix_mode,
12581258

12591259
if (rect != 0)
12601260
{
1261-
/* if clip is present, still check if its needed */
1261+
/* if clip is present, still check if it's needed */
12621262
if (MIN(endx, startx) < rect->left ||
12631263
MIN(endy, starty) < rect->top ||
12641264
MAX(endx, startx) >= rect->right ||
@@ -1460,7 +1460,7 @@ xrdp_orders_mem_blt(struct xrdp_orders *self, int cache_id,
14601460

14611461
if (rect != 0)
14621462
{
1463-
/* if clip is present, still check if its needed */
1463+
/* if clip is present, still check if it's needed */
14641464
if (x < rect->left || y < rect->top ||
14651465
x + cx > rect->right || y + cy > rect->bottom)
14661466
{
@@ -1667,7 +1667,7 @@ xrdp_orders_composite_blt(struct xrdp_orders* self, int srcidx, int srcformat,
16671667
self->orders_state.last_order = RDP_ORDER_COMPOSITE;
16681668
if (rect != 0)
16691669
{
1670-
/* if clip is present, still check if its needed */
1670+
/* if clip is present, still check if it's needed */
16711671
if (dstx < rect->left || dsty < rect->top ||
16721672
dstx + width > rect->right || dsty + height > rect->bottom)
16731673
{
@@ -1999,7 +1999,7 @@ xrdp_orders_text(struct xrdp_orders *self,
19991999

20002000
if (rect != 0)
20012001
{
2002-
/* if clip is present, still check if its needed */
2002+
/* if clip is present, still check if it's needed */
20032003
if ((box_right - box_left > 1 &&
20042004
(box_left < rect->left ||
20052005
box_top < rect->top ||

libxrdp/xrdp_sec.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2101,7 +2101,7 @@ xrdp_sec_in_mcs_data(struct xrdp_sec *self)
21012101

21022102
client_info = &(self->rdp_layer->client_info);
21032103
s = &(self->client_mcs_data);
2104-
/* get hostname, its unicode */
2104+
/* get hostname, it's unicode */
21052105
s->p = s->data;
21062106
if (!s_check_rem(s, 47))
21072107
{

prog_std.txt

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11

22
This is an attempt to explain my odd programming standard used for this project.
3-
Not to defend any of these but its my default standard and make it easy
4-
for me to read.
3+
Not to defend any of these but it's my default standard and it makes it easy
4+
for me to read code.
5+
56
Some files break these rules, they will be updated eventually.
67

78
try to make any file compile with c++ compilers
@@ -30,7 +31,7 @@ don't use tabs, use spaces
3031

3132
no line should exceed 80 chars
3233

33-
always use {} in if and while, even if its only one line
34+
always use {} in if and while, even if it's only one line
3435
while (p != 0)
3536
{
3637
p = p->next;

sesman/sessvc/sessvc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ nil_signal_handler(int sig)
4949
}
5050

5151
/******************************************************************************/
52-
/* chansrv can exit at any time without cleaning up, its an xlib app */
52+
/* chansrv can exit at any time without cleaning up, it's an xlib app */
5353
int APP_CC
5454
chansrv_cleanup(int pid)
5555
{

tests/gtcp_proxy/gtcp.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ int tcp_socket_create(void)
3333
unsigned int option_len;
3434
#endif
3535

36-
/* in win32 a socket is an unsigned int, in linux, its an int */
36+
/* in win32 a socket is an unsigned int, in linux, it's an int */
3737
if ((rv = (int) socket(PF_INET, SOCK_STREAM, 0)) < 0)
3838
return -1;
3939

@@ -193,7 +193,7 @@ int tcp_socket(void)
193193
unsigned int option_len;
194194
#endif
195195

196-
/* in win32 a socket is an unsigned int, in linux, its an int */
196+
/* in win32 a socket is an unsigned int, in linux, it's an int */
197197
if ((rv = (int) socket(PF_INET, SOCK_STREAM, 0)) < 0)
198198
return -1;
199199

xorg/X11R7.6/rdp/rdpinput.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ keyboard and mouse stuff
2727
num lock */
2828
/* this should be fixed in rdesktop */
2929
/* g_pause_spe flag for special control sent by ms client before scan code
30-
69 is sent to tell that its pause, not num lock. both pause and num
30+
69 is sent to tell that it's pause, not num lock. both pause and num
3131
lock use scan code 69 */
3232

3333
/* tab notes */

xrdp/xrdp.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -443,8 +443,7 @@ main(int argc, char **argv)
443443

444444
if (fd == -1)
445445
{
446-
g_writeln("problem opening to xrdp.pid [%s]", pid_file);
447-
g_writeln("maybe its not running");
446+
g_writeln("cannot open %s, maybe xrdp is not running", pid_file);
448447
}
449448
else
450449
{

xrdp/xrdp_types.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ struct xrdp_brush_item
216216
{
217217
int stamp;
218218
/* expand this to a structure to handle more complicated brushes
219-
for now its 8x8 1bpp brushes only */
219+
for now it's 8x8 1bpp brushes only */
220220
char pattern[8];
221221
};
222222

xrdp/xrdp_wm.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1725,8 +1725,8 @@ callback(long id, int msg, long param1, long param2, long param3, long param4)
17251725
rv = xrdp_wm_process_input_mousex(wm, param3, param1, param2);
17261726
break;
17271727
case 0x4444: /* invalidate, this is not from RDP_DATA_PDU_INPUT */
1728-
/* like the rest, its from RDP_PDU_DATA with code 33 */
1729-
/* its the rdp client asking for a screen update */
1728+
/* like the rest, it's from RDP_PDU_DATA with code 33 */
1729+
/* it's the rdp client asking for a screen update */
17301730
MAKERECT(rect, param1, param2, param3, param4);
17311731
rv = xrdp_bitmap_invalidate(wm->screen, &rect);
17321732
break;

xrdp/xrdpwin.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -466,8 +466,8 @@ main(int argc, char **argv)
466466

467467
if (fd == -1)
468468
{
469-
g_writeln("problem opening to xrdp.pid");
470-
g_writeln("maybe its not running");
469+
g_writeln("cannot open %s, maybe xrdp is not running",
470+
pid_file);
471471
}
472472
else
473473
{

0 commit comments

Comments
 (0)