-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TRPC 11.x.x (next) introduces breaking changes that will break electron-trpc #184
Comments
Hey, thanks so much for doing this! ❤️ I'm happy to accept your changes if you'd like to open a PR. Otherwise, I'll catch up with the latest TRPC in this repo soon. |
@jsonnull Hey, thanks for getting back to me, I'll create a PR tomorrow with all of those changes. |
Just bumping this issue if that's ok. I know there's a PR already and adding support for TRPC v11+ and thus React Query v5 would be really welcome indeed :) I'm happy to help and test! |
This PR worked for me with no issues. It'd be great if it could be merged. |
I was going mad not understanding where this issue came from, I was able to make my app work by installing trpc packages back to version 10 and react-query to version 4 🥲 |
Mean while until this PR is merged, @mat-sz has created his own npm package trpc-electron which addresses this issue. It's working well for me with TRPC v11 and React Query v5. |
is there a plan to merge trpc-electron into electron-trpc? |
i'm hitting this issue with electron-trpc (want v11) gonna check out this other repo |
One of the breaking changes involves transformers, the error manifests itself on client side as:
With this line being at fault:
electron-trpc/packages/electron-trpc/src/renderer/ipcLink.ts
Line 97 in 784bbb0
I've forked the repository and resolved the compatibility issues with the next version of TRPC: mat-sz@994bd41
Since this is an unstable version of TRPC, I'm not submitting this as a pull request. If you'd like me to submit that in the future when 11.x.x becomes stable, please let me know; otherwise I'll continue maintaining this as a fork.
The text was updated successfully, but these errors were encountered: