Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRPC 11.x.x (next) introduces breaking changes that will break electron-trpc #184

Open
mat-sz opened this issue Feb 27, 2024 · 9 comments
Open

Comments

@mat-sz
Copy link

mat-sz commented Feb 27, 2024

One of the breaking changes involves transformers, the error manifests itself on client side as:

Uncaught TypeError: Cannot read properties of undefined (reading 'serialize')

With this line being at fault:

op.input = runtime.transformer.serialize(op.input);

I've forked the repository and resolved the compatibility issues with the next version of TRPC: mat-sz@994bd41

Since this is an unstable version of TRPC, I'm not submitting this as a pull request. If you'd like me to submit that in the future when 11.x.x becomes stable, please let me know; otherwise I'll continue maintaining this as a fork.

@jsonnull
Copy link
Owner

jsonnull commented May 3, 2024

Hey, thanks so much for doing this! ❤️

I'm happy to accept your changes if you'd like to open a PR. Otherwise, I'll catch up with the latest TRPC in this repo soon.

@mat-sz
Copy link
Author

mat-sz commented May 3, 2024

@jsonnull Hey, thanks for getting back to me, I'll create a PR tomorrow with all of those changes.

@mat-sz
Copy link
Author

mat-sz commented May 4, 2024

@jsonnull Created a PR - #194

@theorib
Copy link

theorib commented Aug 27, 2024

Just bumping this issue if that's ok. I know there's a PR already and adding support for TRPC v11+ and thus React Query v5 would be really welcome indeed :) I'm happy to help and test!

@dsaltares
Copy link

dsaltares commented Sep 13, 2024

This PR worked for me with no issues. It'd be great if it could be merged.
For now, I just copied the files locally and applied the patch. Otherwise, I would use this fantastic package!

@nonua
Copy link

nonua commented Oct 9, 2024

I was going mad not understanding where this issue came from, I was able to make my app work by installing trpc packages back to version 10 and react-query to version 4 🥲

@theorib
Copy link

theorib commented Oct 21, 2024

I was going mad not understanding where this issue came from, I was able to make my app work by installing trpc packages back to version 10 and react-query to version 4 🥲

Mean while until this PR is merged, @mat-sz has created his own npm package trpc-electron which addresses this issue. It's working well for me with TRPC v11 and React Query v5.

@hyusetiawan
Copy link

is there a plan to merge trpc-electron into electron-trpc?

@sebbean
Copy link

sebbean commented Dec 29, 2024

i'm hitting this issue with electron-trpc (want v11) gonna check out this other repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants