Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secretVolumeMount from k8s-libsonnet hardcodes the volume name to secret name #490

Open
davidovich opened this issue Dec 16, 2024 · 1 comment

Comments

@davidovich
Copy link
Contributor

If the secret has a valid name with dots in it (my-cluster.example.com) you will not be able to use the secretVolumeMount because it uses the secret name as a volume name where dots are not allowed.

We could:

  • Allow overriding the volumeName,
  • sanitize the volume name (removing the dots) before naming the volume.
@Duologic
Copy link
Member

I wrote a small function that can sanitize it here: https://github.com/jsonnet-libs/xtd/blob/master/docs/ascii.md#fn-stringtorfc1123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants