Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Clarity around omitting HTTP method on CBV #244

Open
jensenbox opened this issue May 10, 2021 · 0 comments
Open

Documentation: Clarity around omitting HTTP method on CBV #244

jensenbox opened this issue May 10, 2021 · 0 comments

Comments

@jensenbox
Copy link

When applying @method_decorator(ratelimit(key='ip', rate='1/m', method='GET'), name='get') to an entire class, there is a bit of confusion I have about the inclusion of the HTTP method.

What happens if one were to leave it off? I think the documentation can make this a little clearer by either adding a second application of the decorator for POST or perhaps indicate if it will then handle all HTTP methods.

Additionally, if the name kwarg is not supplied, what happens then as well?

Thanks for the great software!

I would be happy to edit the docs to whatever the answer ends up being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant