Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove() method does not work #30

Open
JacekZakowicz opened this issue Sep 27, 2019 · 0 comments
Open

remove() method does not work #30

JacekZakowicz opened this issue Sep 27, 2019 · 0 comments

Comments

@JacekZakowicz
Copy link

Hello,

I have found out that remove() method does not work properly.
Currently it looks like this:

remove(el, binding) {
    for(let item of this.items){
      if(item.el === el){
        this.items.splice(this.items.indexOf(el), 1)
      }
    }
  }

As we can see no elements are actually removed from the array. In order to make it work properly it should be:

remove(el, binding) {
    for(let item of this.items){
      if(item.el === el){
        this.items.splice(this.items.indexOf(item), 1)
        break
      }
    }
  }

I would make a pull request but somehow can't succeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant