From 46d488fb8718ae245bc9f711cae700d5730d87f3 Mon Sep 17 00:00:00 2001 From: Carlos Serrano Date: Mon, 29 Apr 2024 09:09:00 +0200 Subject: [PATCH] ci: pin nyc in node@8 and skip node@9 (#49) PR-URL: https://github.com/jshttp/on-finished/pull/49 REF: https://github.com/jshttp/on-finished/issues/48 and https://github.com/jshttp/http-errors/pull/109 --- .github/workflows/ci.yml | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 096d494..3780ed3 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -22,6 +22,9 @@ jobs: - Node.js 7.x - Node.js 8.0 # test early async_hooks - Node.js 8.x + # test fail on Node.js 9.x for unknown reasons + # See https://github.com/jshttp/on-finished/pull/49 for more information. + # - Node.js 9.x - Node.js 10.x - Node.js 11.x - Node.js 12.x @@ -80,8 +83,13 @@ jobs: - name: Node.js 8.x node-version: "8.17" - npm-i: mocha@7.2.0 + npm-i: mocha@7.2.0 nyc@14.1.1 + # test fail on Node.js 9.x for unknown reasons + # See https://github.com/jshttp/on-finished/pull/49 for more information. + # - name: Node.js 9.x + # node-version: "9.11" + # npm-i: mocha@7.2.0 nyc@14.1.1 - name: Node.js 10.x node-version: "10.24" npm-i: mocha@8.4.0