jenv support would benefit from being able to provide project root as a setting

[timolehto]

It turns out that when vscode is using find-java-home it is not running it from the project root folder, but somewhere else. This makes it so that jenv doesn't pick up the local .java-version file for the project, but rather instead it uses the globally set jenv java version. So while this #26 does work, it doesn't work quite as well as I had hoped.

I could work on a followup PR, which would allow setting the project root if that sounds like something you'd be willing to accept, @jsdevel?

redhat-developer/vscode-java#1104 (comment)

[jsdevel]

hmm, is there a way to configure vscode to set the cwd for find-java-home to your directory containing .java-version?

[timolehto]

Well, I kind of tried to suggest that, but it seemed they weren't too keen on it. Essentially it's the only viable solution on this side as well to support the "project root" so it's anyways gonna be that particular working dir swapping code that's gonna need to be added somewhere and the question here is should it be part of this library or the plugin or should I create a wrapper/extension library which would provide the project root option for the vscode-java plugin and handle the working directory swapping so that this library can remain clean.

I'll still try to reason about this with them.

[timolehto]

The downside of pushing this to vscode-java is though that an explicit option might be easier to discover and realise for users of this library instead of some (yet un)documented expectation of this plugin that you're suppose to be in the project root folder for this to work (though, for someone caring about jenv that shouldn't strike too odd).

[jsdevel]

what would the CLI API look like if support were added here?

[manastalukdar]

Any update on this? Thanks.

[timolehto]

Why do you ask @manastalukdar? Are you asking because vscode is not supporting this properly or do you have some other usecase in mind?

[manastalukdar]

@timolehto Because I would like vscode to pick up the local jenv.

[timolehto]

@jsdevel after some significant silence time.. I'm back thinking about this (thanks for the reminder mana). Sorry, what are you talking about? What cli api? Is there a cli for node-find-java-home? I don't see that. Am I blind?

[manastalukdar]

Bump.

[manastalukdar]

Checking in after a year. Any update?

[jsdevel]

i'm willing to accept any solution the community finds desireable.