Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated tests #101

Closed
jimaek opened this issue Oct 22, 2022 · 2 comments · Fixed by #106
Closed

Automated tests #101

jimaek opened this issue Oct 22, 2022 · 2 comments · Fixed by #106
Assignees
Labels

Comments

@jimaek
Copy link
Member

jimaek commented Oct 22, 2022

In the early days we broke everything at least 2 or 3 times because we forgot or missed stuff. We need to write lots of detailed tests both unit and functional and simulate many conditions to ensure new releases won't break anything. Especially the auto-update logic.
It would be a lot more catastrophic now. I actually think we still have like 100 probes stuck forever waiting for the container to get rebooted by someone.
Let's ensure this never happens again

@alexey-yarmosh
Copy link
Member

Sounds valid, the only thing is that we should solve jsdelivr/globalping#262 first, as the same problem will occur in globalping-probe repo.

@github-actions
Copy link

github-actions bot commented Feb 5, 2023

🎉 This issue has been resolved in version 0.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants