feat: add 404 page #473
Open
feat: add 404 page #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jsconf-jp-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hey @martinheidegger, I've setup a 404 page. Is there something specific I need to do to make it work for all the years? |
martinheidegger
requested changes
Oct 29, 2024
There was a problem hiding this comment.
Please rebase as the translation files seem to be out of sync.
Is there something specific I need to do to make it work for all the years?
Yes, I think you need to look in the build process and make sure that a 404 page gets deployed. Please refer to the hosting documentation. I think it is published on Netlify:
jsconf.jp/.github/workflows/CD.yml
Line 25 in 3e581a5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #470