-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stray smart quote in Makefile #5
Comments
It occurs to me the Makefile looks like it's been replaced by the webpack build; should it be removed? |
Yes, originally started with a makefile, but then started using npm scripts cause easier. But now if the scripts start getting longer, it might make more sense to just use a separate make or build script again. Maybe remove for now? |
Actually it does make more sense to use makefile. Going move the build scripts to there. Just added a new one to build the ogv example |
My one warning on using a Makefile is that it's harder to make a local build that works on both Unix and Windows. For ogv.js I'm planning to split out the emscripten-built modules, which require a Unix build infrastructure for all the autoconf libraries anyway, and avoid Makefiles on the front-end build in favor of Grunt. |
That is a very good point. Npm for now it is! |
The text was updated successfully, but these errors were encountered: