Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stray smart quote in Makefile #5

Open
bvibber opened this issue Feb 17, 2017 · 5 comments
Open

stray smart quote in Makefile #5

bvibber opened this issue Feb 17, 2017 · 5 comments

Comments

@bvibber
Copy link
Contributor

bvibber commented Feb 17, 2017

$ make
rm -rf build 
mkdir build  
VERSION=`node -pe "require('./package.json').version"` && \
	browserify src/main.js -t [ envify purge --MODE global ] | \
	tee  build/flare-vpx-“$VERSION".js 
/bin/sh: -c: line 0: unexpected EOF while looking for matching `"'
/bin/sh: -c: line 1: syntax error: unexpected end of file
make: *** [build-release] Error 2
bvibber added a commit to bvibber/jsvpx that referenced this issue Feb 17, 2017
@bvibber
Copy link
Contributor Author

bvibber commented Feb 17, 2017

It occurs to me the Makefile looks like it's been replaced by the webpack build; should it be removed?

@brianxautumn
Copy link
Member

Yes, originally started with a makefile, but then started using npm scripts cause easier. But now if the scripts start getting longer, it might make more sense to just use a separate make or build script again. Maybe remove for now?

@brianxautumn
Copy link
Member

Actually it does make more sense to use makefile. Going move the build scripts to there. Just added a new one to build the ogv example

@bvibber
Copy link
Contributor Author

bvibber commented Feb 17, 2017

My one warning on using a Makefile is that it's harder to make a local build that works on both Unix and Windows.

For ogv.js I'm planning to split out the emscripten-built modules, which require a Unix build infrastructure for all the autoconf libraries anyway, and avoid Makefiles on the front-end build in favor of Grunt.

@brianxautumn
Copy link
Member

That is a very good point. Npm for now it is!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants