Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bin.meta should insert after <head> #1

Open
remy opened this issue Jul 13, 2015 · 3 comments
Open

bin.meta should insert after <head> #1

remy opened this issue Jul 13, 2015 · 3 comments

Comments

@remy
Copy link
Member

remy commented Jul 13, 2015

See cross post issue from @jsbin/jsbin: jsbin/jsbin#2354
@remy remy mentioned this issue Jul 13, 2015
Closed
@daviferreira daviferreira mentioned this issue Dec 1, 2015
Closed
@elderfo
Copy link

elderfo commented Dec 6, 2016

@remy, I took a look at this and have a fix at the ready. I was curious of your thoughts of changing the generated file from this:

<!DOCTYPE html>
<!--
Created using JS Bin
http://localhost:3000

Copyright (c) 2016 by anonymous (http://localhost:3000/duc/1/edit)

Released under the MIT license: http://jsbin.mit-license.org
-->
<meta name="robots" content="noindex">
<html>
<head>
  <meta charset="utf-8">
  <meta name="viewport" content="width=device-width">
  <title>JS Bin</title>
</head>
<body>
  <Div>stuff</div>
</body>
</html>

... and moving the comment block to head:

<!DOCTYPE html>
<html>
<head>
  <!--
  Created using JS Bin
  http://localhost:3000

  Copyright (c) 2016 by anonymous (http://localhost:3000/duc/1/edit)

  Released under the MIT license: http://jsbin.mit-license.org
  -->
  <meta name="robots" content="noindex">
  <meta charset="utf-8">
  <meta name="viewport" content="width=device-width">
  <title>JS Bin</title>
</head>
<body>
  <Div>stuff</div>
</body>
</html>

If you are ok with this, I will submit a PR.

@remy
Copy link
Member Author

remy commented Dec 6, 2016

I'd be okay with it, but you'll need to include tests, that specifically test when a head tag isn't included (which is why it's where it is right now).

@elderfo
Copy link

elderfo commented Dec 6, 2016

I will make sure and cover those scenarios and then submit a PR

@elderfo elderfo mentioned this issue Dec 7, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@remy @elderfo