Skip to content

Create tests for specifying other key when loading a "with" relation #66

@techniq

Description

@techniq
Member

Need to create some tests for this change, which requires some new non-standard tables/relations to test against

Activity

jmdobry

jmdobry commented on Mar 11, 2016

@jmdobry
Member

Take note, the new adapter specification in 3.x accomplishes something similar but in a different fashion. It uses methods that the user can override in order to pick or otherwise transform the keys.

techniq

techniq commented on Mar 11, 2016

@techniq
MemberAuthor

Awesome. I need to take a look at them.

On Thu, Mar 10, 2016, 11:58 PM Jason Dobry notifications@github.com wrote:

Take note, the new adapter specification in 3.x accomplishes something
similar but in a different fashion. It uses methods that the user can
override in order to pick or otherwise transform the keys.


Reply to this email directly or view it on GitHub
#66 (comment).

jmdobry

jmdobry commented on Mar 11, 2016

@jmdobry
Member

I've actually managed to extract a lot of common adapter functionality into a base Adapter class, which saves a lot of boilerplate. If you take a look at say js-data-mongodb v1 you'll see that it only has to provide a few MongoDB specifics, but it was full lifecycle hook, debug logging, and relation eager-loading support.

The base class also makes it much easier to keep adapters in sync as far as the adapter interface goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @techniq@jmdobry

        Issue actions

          Create tests for specifying other key when loading a "with" relation · Issue #66 · js-data/js-data-sql