Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.13 support #1893

Open
micahellison opened this issue May 21, 2024 · 2 comments
Open

Add Python 3.13 support #1893

micahellison opened this issue May 21, 2024 · 2 comments
Labels
enhancement New feature or request 📌 This can't go stale

Comments

@micahellison
Copy link
Member

micahellison commented May 21, 2024

Use Case/Motivation

Python 3.13 beta is out, so it's time to start looking into adding support for it.

Target date for Python 3.13 final is October 1 (PEP 719).

Example Usage

n/a

Other Information

Relates to:

@micahellison micahellison added enhancement New feature or request 🆕 New! 📌 This can't go stale and removed 🆕 New! labels May 21, 2024
@musicinmybrain
Copy link
Contributor

If I change

python = ">=3.10.0, <3.13"

to

python = ">=3.10.0, <3.14"

then, in a Python 3.13.0b1 virtualenv (the pip install cffi is a temporary workaround),

$ poetry install
$ pip install cffi==1.17.0rc1
$ python -m pytest

then I encounter a single test failure on Python 3.13:

=========================================================================================== short test summary info ============================================================================================
FAILED tests/unit/test_export.py::TestYaml::test_export_to_nonexisting_folder - SystemError: error return without exception set
================================================================================== 1 failed, 644 passed, 40 skipped in 1.93s ===================================================================================

@micahellison
Copy link
Member Author

Thanks for running those tests, @musicinmybrain. That's a useful note about cffi -- we'll have to stayed tuned for their eventual Python 3.13 support.

I got the same result after installing that cffi release candidate. Strangely, when I run those unit tests by themselves, they all pass:

$ poetry run pytest
...
FAILED tests/unit/test_export.py::TestYaml::test_export_to_nonexisting_folder - SystemError: error return without exception set
...

$ poetry run pytest tests/unit/test_export.py
============================================================== test session starts ===============================================================
platform linux -- Python 3.13.0b1, pytest-8.0.0, pluggy-1.3.0
rootdir: /home/micah/dev/jrnl
configfile: pyproject.toml
plugins: bdd-7.0.1, clarity-1.0.1, xdist-3.5.0
8 workers [2 items]     
..                                                                                                                                         [100%]
=============================================================== 2 passed in 1.58s ================================================================

Also, I haven't tested on Windows yet, or on Mac through GitHub actions, but we may also have to wait on Python 3.13 compatible wheels of various dependencies if there are installation failures there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 📌 This can't go stale
Projects
None yet
Development

No branches or pull requests

2 participants